Merged
Conversation
MateoLostanlen
force-pushed
the
feat/detection-pose-id
branch
from
a0a1cbf to
46aee4c
Compare
| for pos_id, cam_azimuth in zip(cam_poses, cam_azimuths, strict=False): | ||
| splitted_cam_creds[ip + "_" + str(pos_id)] = (cam_data["token"], cam_azimuth, bbox_mask_url) | ||
| cam_pose_ids = cam_data["pose_ids"] | ||
| for pos_id, pose_id in zip(cam_poses, cam_pose_ids, strict=False): |
Member
There was a problem hiding this comment.
we need to update theses names, too similar
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
===========================================
+ Coverage 72.59% 73.27% +0.68%
===========================================
Files 7 7
Lines 602 610 +8
===========================================
+ Hits 437 447 +10
+ Misses 165 163 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR to close #328 Adapt detection creation to pyro-api updates
It introduces the following modifications :
Now, it has to be tested on few sites, and need to work on updating credentials on all rpi fleet.
Happy to discuss it